Conversation
nvh
approved these changes
Nov 27, 2018
src/hooks/use-viewport-scroll.ts
Outdated
| y.set(window.pageYOffset) | ||
| } | ||
|
|
||
| window.addEventListener("scroll", onScroll, { passive: true }) |
Contributor
There was a problem hiding this comment.
This could use the useEvent hook
src/hooks/use-viewport-scroll.ts
Outdated
| useEffect(() => { | ||
| const onScroll = () => { | ||
| x.set(window.pageXOffset) | ||
| y.set(window.pageYOffset) |
Contributor
There was a problem hiding this comment.
Is this a cross browser value?
Collaborator
Author
There was a problem hiding this comment.
Yeah nowadays this is fine https://developer.mozilla.org/en-US/docs/Web/API/Window/pageXOffset
src/hooks/use-transform.ts
Outdated
| transformer: interpolate(from, to), | ||
| }) | ||
|
|
||
| const transformer = interpolate(from, to) as Transformer<any> |
Collaborator
Author
There was a problem hiding this comment.
It used to moan, now it doesn't for some reason!
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.